Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue when external apps request WC proposal to estimate gas #483

Merged
merged 1 commit into from
Mar 29, 2024

Conversation

santteegt
Copy link
Contributor

GitHub Issue

None

Changes

The Tx type not supported error was reported when trying to use the WalletConnect proposal to catch a transaction from the Superfluid dApp. This happens as the app requests the wallet provider to estimate gas for the individual action before submitting the tx payload. In the case of the WC proposal this isn't required so it's fine to return zero

Packages Added

None

Checks

Before making your PR, please check the following:

  • Critical lint errors are resolved
  • App runs locally
  • App builds locally (run the build command for any impacted package and check for any errors before the PR)

@santteegt santteegt requested a review from skuhlmann March 27, 2024 23:08
@skuhlmann skuhlmann merged commit 0113897 into develop Mar 29, 2024
1 check passed
@skuhlmann skuhlmann deleted the fix/wc-prop-request-error branch June 11, 2024 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants